Add CHECK_FOR_INTERRUPTS() in scram_SaltedPassword() for the backend
authorMichael Paquier <michael@paquier.xyz>
Mon, 27 Nov 2023 23:35:50 +0000 (08:35 +0900)
committerMichael Paquier <michael@paquier.xyz>
Mon, 27 Nov 2023 23:35:50 +0000 (08:35 +0900)
commit14f2f9eb1a15f234f1ef417b8e62a6b7f950be4d
treed2be134739afc0526f402f3f047bb0d4e83b8eaf
parent930d2b442ff12e6d466a8c62cecdf3f17680aa3e
Add CHECK_FOR_INTERRUPTS() in scram_SaltedPassword() for the backend

scram_SaltedPassword() could take a long time to compute when the number
of iterations used is large enough, and this code uses a tight loop to
compute a salted password.

Note that the same issue exists in libpq when using \password and a
large iteration number, but this cannot be interrupted.  A CFI in the
backend is useful for server-side computations, at least.

Backpatch down to 16, where the user-settable GUC scram_iterations has
been added.

Author: Bowen Shi
Reviewed-by: Aleksander Alekseev, Daniel Gustafsson
Discussion: https://postgr.es/m/CAM_vCueV6xfr08KczfaCEk5J_qeTZtgqN7+orkNLx=g+phE82Q@mail.gmail.com
Backpatch-through: 16
src/common/scram-common.c