Fix race in SSI interaction with gin fast path.
authorThomas Munro <tmunro@postgresql.org>
Mon, 3 Jul 2023 04:20:01 +0000 (16:20 +1200)
committerThomas Munro <tmunro@postgresql.org>
Mon, 3 Jul 2023 21:07:31 +0000 (09:07 +1200)
commit126552c85c1cfb6ce6445159b8024cfa5631f33e
tree43c4eb1f099a5c418cb42c28510fadc0ac62ba02
parentbcc93a389ce3862c9a15ae2f079d87bbc6a2228f
Fix race in SSI interaction with gin fast path.

The ginfast.c code previously checked for conflicts in before locking
the relevant buffer, leaving a window where a RW conflict could be
missed.  Re-order.

There was also a place where buffer ID and block number were confused
while trying to predicate-lock a page, noted by visual inspection.

Back-patch to all supported releases.  Fixes one more problem discovered
with the reproducer from bug #17949, in this case when Dmitry tried
other index types.

Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>
Reported-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
src/backend/access/gin/ginfast.c
src/backend/access/gin/ginget.c