Simplify executor's handling of CaseTestExpr & CoerceToDomainValue.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 30 Jan 2025 18:21:42 +0000 (13:21 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 30 Jan 2025 18:21:42 +0000 (13:21 -0500)
commit115a365519bfd53a65bf17d253b26902eff0c337
tree809dcf8dcfd0ec0b82fce588557af80073005b02
parent6252b1eaf82bb8db361341d1c8651e43b29be816
Simplify executor's handling of CaseTestExpr & CoerceToDomainValue.

Instead of deciding at runtime whether to read from casetest.value
or caseValue_datum, split EEOP_CASE_TESTVAL into two opcodes and
make the decision during expression compilation.  Similarly for
EEOP_DOMAIN_TESTVAL.  This actually results in net less code,
mainly because llvmjit_expr.c's code for handling these opcodes
gets shorter.  The performance gain is doubtless negligible, but
this seems worth changing anyway on grounds of simplicity and
understandability.

Author: Andreas Karlsson <andreas@proxel.se>
Co-authored-by: Xing Guo <higuoxing@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACpMh+AiBYAWn+D1aU7Rsy-V1tox06Cbc0H3qA7rwL5zdJ=anQ@mail.gmail.com
src/backend/executor/execExpr.c
src/backend/executor/execExprInterp.c
src/backend/jit/llvm/llvmjit_expr.c
src/include/executor/execExpr.h