Remove vacuum_defer_cleanup_age
authorAndres Freund <andres@anarazel.de>
Mon, 24 Apr 2023 19:20:52 +0000 (12:20 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 24 Apr 2023 19:21:02 +0000 (12:21 -0700)
commit1118cd37eb61e6a2428f457a8b2026a7bb3f801a
treeda41a7760d5fa409a97069c7e505e98a5a0bdf4f
parent441ee1677e6b580794c81943a937cd84363672f3
Remove vacuum_defer_cleanup_age

vacuum_defer_cleanup_age was introduced before hot_standby_feedback and
replication slots existed. It is hard to use reasonably - commonly it will
either be set too low (not preventing recovery conflicts, while still causing
some bloat), or too high (causing a lot of bloat). The alternatives do not
have that issue.

That on its own might not be sufficient reason to remove
vacuum_defer_cleanup_age, but it also complicates computation of xid
horizons. See e.g. the bug fixed in be504a3e974. It also is untested.

This commit removes TransactionIdRetreatSafely(), as there are no users
anymore. There might be potential future users, hence noting that here.

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20230317230930.nhsgk3qfk7f4axls@awork3.anarazel.de
doc/src/sgml/config.sgml
doc/src/sgml/high-availability.sgml
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/standby.c
src/backend/utils/misc/guc_tables.c
src/backend/utils/misc/postgresql.conf.sample
src/bin/pg_upgrade/server.c
src/include/storage/standby.h