Fix issue in recovery test 041_checkpoint_at_promote
authorMichael Paquier <michael@paquier.xyz>
Wed, 12 Feb 2025 08:58:25 +0000 (17:58 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 12 Feb 2025 08:58:25 +0000 (17:58 +0900)
commit0fc68c8421b656f2ad03e788d97ff0c59da60e6f
tree337c555eeb6acf85ffb0c2732ed87f6f9d887cea
parent5b94e2753439b699b78aacbb53e89bf0e814becc
Fix issue in recovery test 041_checkpoint_at_promote

The phase of the test waiting for a restartpoint to complete was not
working as intended, due to a log_contains() call incorrectly
written.

The problem reported by the author could be simply reproduced by
removing the injection_points_wakeup() call: the test succeeds rather
than waiting for the restartpoint completion.  In most cases, the
restartpoint completion is fast enough that the test offered the wanted
coverage.  On slow machines, it could have become unreliable.

Oversight in 6782709df81f.

Author: Nitin Jadhav
Discussion: https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.com
Backpatch-through: 17
src/test/recovery/t/041_checkpoint_at_promote.pl