Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 22 Feb 2021 19:51:44 +0000 (16:51 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 22 Feb 2021 19:51:44 +0000 (16:51 -0300)
commit0f5505a8815aa4eb03ca61245a5a51ff9adda2f4
treeb3237cda63b8e40c3fa909f5c084a83fa0ea365a
parent6a03369a71d4a7dc5b8d928aab775ddd28b72494
Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls

Pavan Deolasee recently noted that a few of the
HeapTupleHeaderIndicatesMovedPartitions calls added by commit
5db6df0c0117 are useless, since they are done after comparing t_self
with t_ctid.  But because t_self can never be set to the magical values
that indicate that the tuple moved partition, this can never succeed: if
the first test fails (so we know t_self equals t_ctid), necessarily the
second test will also fail.

So these checks can be removed and no harm is done.  There's no bug
here, just a code legibility issue.

Reported-by: Pavan Deolasee <pavan.deolasee@gmail.com>
Discussion: https://postgr.es/m/20200929164411.GA15497@alvherre.pgsql
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam_visibility.c