Refactor WAL file-reading code into WALRead()
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 25 Nov 2019 18:04:54 +0000 (15:04 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 25 Nov 2019 18:04:54 +0000 (15:04 -0300)
commit0dc8ead46363fec6f621a12c7e1f889ba73b55a9
treeae1eb1d20970c69eeac44e57a44f4315b5223ea0
parent5883f5fe27d7b52c812dd0f8cbda67373a14c451
Refactor WAL file-reading code into WALRead()

XLogReader, walsender and pg_waldump all had their own routines to read
data from WAL files to memory, with slightly different approaches
according to the particular conditions of each environment.  There's a
lot of commonality, so we can refactor that into a single routine
WALRead in XLogReader, and move the differences to a separate (simpler)
callback that just opens the next WAL-segment.  This results in a
clearer (ahem) code flow.

The error reporting needs are covered by filling in a new error-info
struct, WALReadError, and it's the caller's responsibility to act on it.
The backend has WALReadRaiseError() to do so.

We no longer ever need to seek in this interface; switch to using
pg_pread().

Author: Antonin Houska, with contributions from Álvaro Herrera
Reviewed-by: Michaël Paquier, Kyotaro Horiguchi
Discussion: https://postgr.es/m/14984.1554998742@spoje.net
src/backend/access/transam/xlogreader.c
src/backend/access/transam/xlogutils.c
src/backend/replication/walsender.c
src/bin/pg_waldump/pg_waldump.c
src/include/access/xlogreader.h
src/include/access/xlogutils.h