Fix overridden callbacks in pg_rewind.
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 2 May 2023 11:15:29 +0000 (13:15 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 2 May 2023 11:15:29 +0000 (13:15 +0200)
commit08237056f84e3a9ed75e8a698428c669f4d35db4
treede2553f4f5e154f0011d32e678d6c1519ca3e211
parente0bb5d0c5bcada63dc9b8a1a72a344a07bf930ce
Fix overridden callbacks in pg_rewind.

The <source>_traverse_files functions take a callback for processing
files, but both the local and libpq source implementations called the
function directly without using the callback argument. While there is
no bug right now as the function called is the same as the callback,
fix by calling the callback to reduce the risk of subtle bugs in the
future.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3Jdwgh+PZr2zh1=t8apA4Yz8tKq+uubPqoCt14nvWKHEw@mail.gmail.com
src/bin/pg_rewind/libpq_source.c
src/bin/pg_rewind/local_source.c