Don't repeatedly register cache callbacks in pgoutput plugin.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2023 20:40:27 +0000 (15:40 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2023 20:40:42 +0000 (15:40 -0500)
commit05172f1f37496acc13769b8cc0af6e77591be90f
tree1f52ee3568e67b8a466adf910db37644895c0f56
parent0da243fed0875932f781aff08df782b56af58d02
Don't repeatedly register cache callbacks in pgoutput plugin.

Multiple cycles of starting up and shutting down the plugin within a
single session would eventually lead to "out of relcache_callback_list
slots", because pgoutput_startup blindly re-registered its cache
callbacks each time.  Fix it to register them only once, as all other
users of cache callbacks already take care to do.

This has been broken all along, so back-patch to all supported branches.

Shi Yu

Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com
src/backend/replication/pgoutput/pgoutput.c