Move BuildDescForRelation() from tupdesc.c to tablecmds.c
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 5 Oct 2023 14:17:16 +0000 (16:17 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Thu, 5 Oct 2023 14:20:46 +0000 (16:20 +0200)
commit04e485273b56bec0e4637f97c587eca26cf823f0
tree17f87a575c15c9bbaeab24c26513fd80c330e331
parent6d341407a6e34cd6857cf55ee4757397286542db
Move BuildDescForRelation() from tupdesc.c to tablecmds.c

BuildDescForRelation() main job is to convert ColumnDef lists to
pg_attribute/tuple descriptor arrays, which is really mostly an
internal subroutine of DefineRelation() and some related functions,
which is more the remit of tablecmds.c and doesn't have much to do
with the basic tuple descriptor interfaces in tupdesc.c.  This is also
supported by observing the header includes we can remove in tupdesc.c.
By moving it over, we can also (in the future) make
BuildDescForRelation() use more internals of tablecmds.c that are not
sensible to be exposed in tupdesc.c.

Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org
src/backend/access/common/tupdesc.c
src/backend/commands/tablecmds.c
src/include/access/tupdesc.h
src/include/commands/tablecmds.h