Remove count_one_bits() in acl.c.
authorNathan Bossart <nathan@postgresql.org>
Wed, 12 Mar 2025 20:01:52 +0000 (15:01 -0500)
committerNathan Bossart <nathan@postgresql.org>
Wed, 12 Mar 2025 20:01:52 +0000 (15:01 -0500)
commit025e7e1eb4b884a187ade19f2ed479b256306a82
treef4e47c7a00b00b57c4f8da5eda27d556c5e08f59
parentff79b5b2aba02d720f9b7fff644dd50ce07b8c6e
Remove count_one_bits() in acl.c.

The only caller, select_best_grantor(), can instead use
pg_popcount64().  This isn't performance-critical code, but we
might as well use the centralized implementation.  While at it, add
some test coverage for this part of select_best_grantor().

Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/Z9GtL7Nm6hsYyJnF%40nathan
src/backend/utils/adt/acl.c
src/test/regress/expected/privileges.out
src/test/regress/sql/privileges.sql