Fix bug in WAL replay of COMMIT_TS_SETTS record.
authorFujii Masao <fujii@postgresql.org>
Thu, 25 Mar 2021 02:23:30 +0000 (11:23 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 25 Mar 2021 02:23:30 +0000 (11:23 +0900)
commit438fc4a39c3905b7af88bb848bc5aeb1308a017d
tree06e25d33f71fdc98c1ff0679a37f625357788694
parentdf9384492b89aac370ab9d12eb89375aeb38a1d4
Fix bug in WAL replay of COMMIT_TS_SETTS record.

Previously the WAL replay of COMMIT_TS_SETTS record called
TransactionTreeSetCommitTsData() with the argument write_xlog=true,
which generated and wrote new COMMIT_TS_SETTS record.
This should not be acceptable because it's during recovery.

This commit fixes the WAL replay of COMMIT_TS_SETTS record
so that it calls TransactionTreeSetCommitTsData() with write_xlog=false
and doesn't generate new WAL during recovery.

Back-patch to all supported branches.

Reported-by: lx zou <zoulx1982@163.com>
Author: Fujii Masao
Reviewed-by: Alvaro Herrera
Discussion: https://postgr.es/m/16931-620d0f2fdc6108f1@postgresql.org
src/backend/access/transam/commit_ts.c