Remove some unnecessary variable assignments, per results of "clang"

static checker.  Paul Matthews

diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/utils/adt/geo_ops.c
index 7da8039bcbd4f2d0ac211ee724448e9874cbf894..16e2b7fadb5cb0c70d1252127173dd5bb3e02a52 100644 (file)
--- a/src/backend/utils/adt/geo_ops.c
+++ b/src/backend/utils/adt/geo_ops.c
@@ -2939,7 +2939,7 @@ close_lseg(PG_FUNCTION_ARGS)
                memcpy(&point, &l1->p[1], sizeof(Point));
        }
 
-       if ((d = dist_ps_internal(&l2->p[0], l1)) < dist)
+       if (dist_ps_internal(&l2->p[0], l1) < dist)
        {
                result = DatumGetPointP(DirectFunctionCall2(close_ps,
                                                                                                        PointPGetDatum(&l2->p[0]),
@@ -2950,7 +2950,7 @@ close_lseg(PG_FUNCTION_ARGS)
                                                                                                        LsegPGetDatum(l2)));
        }
 
-       if ((d = dist_ps_internal(&l2->p[1], l1)) < dist)
+       if (dist_ps_internal(&l2->p[1], l1) < dist)
        {
                result = DatumGetPointP(DirectFunctionCall2(close_ps,
                                                                                                        PointPGetDatum(&l2->p[1]),
@@ -2990,7 +2990,7 @@ close_pb(PG_FUNCTION_ARGS)
        point.x = box->low.x;
        point.y = box->high.y;
        statlseg_construct(&lseg, &box->low, &point);
-       dist = d = dist_ps_internal(pt, &lseg);
+       dist = dist_ps_internal(pt, &lseg);
 
        statlseg_construct(&seg, &box->high, &point);
        if ((d = dist_ps_internal(pt, &seg)) < dist)