From bb874e30fbf9e85bdb117bad34865a5fae29dbf6 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sun, 13 Jan 2019 10:50:36 +0100 Subject: [PATCH] Make INSTALL makefile rule more robust With the previous rule, if pandoc was missing, a zero-length output file would be created without an error from make. To improve that, write the rule as two separate commands without a pipe. Reported-by: Tom Lane --- doc/src/sgml/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile index 93b0b60cdb..8326c7c673 100644 --- a/doc/src/sgml/Makefile +++ b/doc/src/sgml/Makefile @@ -103,7 +103,9 @@ ICONV = iconv PANDOC = pandoc INSTALL: % : %.html - $(PANDOC) $< -t plain | $(ICONV) -f utf8 -t us-ascii//TRANSLIT > $@ + $(PANDOC) -t plain -o $@.tmp $< + $(ICONV) -f utf8 -t us-ascii//TRANSLIT $@.tmp > $@ + rm $@.tmp INSTALL.html: %.html : stylesheet-text.xsl %.xml $(XMLLINT) --noout --valid $*.xml -- 2.39.5