From 4fb5c794e58613561f94ad5ea1197729be7791dc Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Mon, 25 Apr 2022 15:00:49 +0200 Subject: [PATCH] Cover brin/gin/gist/spgist ambuildempty routines in regression tests Changing some TEMP or permanent tables to UNLOGGED is sufficient to invoke these ambuildempty routines, which were all not uncovered by any tests. These changes do not otherwise affect the test suite. Author: Amul Sul Discussion: https://postgr.es/m/CAAJ_b95nneRCLM-=qELEdgCYSk6W_++-C+Q_t+wH3SW-hF50iw@mail.gmail.com --- src/test/regress/expected/brin.out | 2 +- src/test/regress/expected/gin.out | 2 +- src/test/regress/expected/gist.out | 2 +- src/test/regress/expected/spgist.out | 2 +- src/test/regress/sql/brin.sql | 2 +- src/test/regress/sql/gin.sql | 2 +- src/test/regress/sql/gist.sql | 2 +- src/test/regress/sql/spgist.sql | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/test/regress/expected/brin.out b/src/test/regress/expected/brin.out index ed7879f583..96cbb5de4e 100644 --- a/src/test/regress/expected/brin.out +++ b/src/test/regress/expected/brin.out @@ -484,7 +484,7 @@ ERROR: block number out of range: -1 SELECT brin_summarize_range('brin_summarize_idx', 4294967296); ERROR: block number out of range: 4294967296 -- test value merging in add_value -CREATE TABLE brintest_2 (n numrange); +CREATE UNLOGGED TABLE brintest_2 (n numrange); CREATE INDEX brinidx_2 ON brintest_2 USING brin (n); INSERT INTO brintest_2 VALUES ('empty'); INSERT INTO brintest_2 VALUES (numrange(0, 2^1000::numeric)); diff --git a/src/test/regress/expected/gin.out b/src/test/regress/expected/gin.out index 6402e89c7f..1a0c3c6167 100644 --- a/src/test/regress/expected/gin.out +++ b/src/test/regress/expected/gin.out @@ -74,7 +74,7 @@ select count(*) > 0 as ok from gin_test_tbl where i @> array[1]; reset gin_fuzzy_search_limit; -- Test optimization of empty queries -create temp table t_gin_test_tbl(i int4[], j int4[]); +create unlogged table t_gin_test_tbl(i int4[], j int4[]); create index on t_gin_test_tbl using gin (i, j); insert into t_gin_test_tbl values diff --git a/src/test/regress/expected/gist.out b/src/test/regress/expected/gist.out index 2393132ed6..a36b4c9c56 100644 --- a/src/test/regress/expected/gist.out +++ b/src/test/regress/expected/gist.out @@ -36,7 +36,7 @@ reindex index gist_pointidx; -- -- Test Index-only plans on GiST indexes -- -create table gist_tbl (b box, p point, c circle); +create unlogged table gist_tbl (b box, p point, c circle); insert into gist_tbl select box(point(0.05*i, 0.05*i), point(0.05*i, 0.05*i)), point(0.05*i, 0.05*i), diff --git a/src/test/regress/expected/spgist.out b/src/test/regress/expected/spgist.out index 1688e0e0a3..51bb9a95c5 100644 --- a/src/test/regress/expected/spgist.out +++ b/src/test/regress/expected/spgist.out @@ -26,7 +26,7 @@ vacuum spgist_point_tbl; -- Test rescan paths (cf. bug #15378) -- use box and && rather than point, so that rescan happens when the -- traverse stack is non-empty -create table spgist_box_tbl(id serial, b box); +create unlogged table spgist_box_tbl(id serial, b box); insert into spgist_box_tbl(b) select box(point(i,j),point(i+s,j+s)) from generate_series(1,100,5) i, diff --git a/src/test/regress/sql/brin.sql b/src/test/regress/sql/brin.sql index 920e053249..eec73b7fbe 100644 --- a/src/test/regress/sql/brin.sql +++ b/src/test/regress/sql/brin.sql @@ -449,7 +449,7 @@ SELECT brin_summarize_range('brin_summarize_idx', -1); SELECT brin_summarize_range('brin_summarize_idx', 4294967296); -- test value merging in add_value -CREATE TABLE brintest_2 (n numrange); +CREATE UNLOGGED TABLE brintest_2 (n numrange); CREATE INDEX brinidx_2 ON brintest_2 USING brin (n); INSERT INTO brintest_2 VALUES ('empty'); INSERT INTO brintest_2 VALUES (numrange(0, 2^1000::numeric)); diff --git a/src/test/regress/sql/gin.sql b/src/test/regress/sql/gin.sql index 5194afcc1f..746880937b 100644 --- a/src/test/regress/sql/gin.sql +++ b/src/test/regress/sql/gin.sql @@ -52,7 +52,7 @@ select count(*) > 0 as ok from gin_test_tbl where i @> array[1]; reset gin_fuzzy_search_limit; -- Test optimization of empty queries -create temp table t_gin_test_tbl(i int4[], j int4[]); +create unlogged table t_gin_test_tbl(i int4[], j int4[]); create index on t_gin_test_tbl using gin (i, j); insert into t_gin_test_tbl values diff --git a/src/test/regress/sql/gist.sql b/src/test/regress/sql/gist.sql index d94a0bb2f7..3360266370 100644 --- a/src/test/regress/sql/gist.sql +++ b/src/test/regress/sql/gist.sql @@ -41,7 +41,7 @@ reindex index gist_pointidx; -- Test Index-only plans on GiST indexes -- -create table gist_tbl (b box, p point, c circle); +create unlogged table gist_tbl (b box, p point, c circle); insert into gist_tbl select box(point(0.05*i, 0.05*i), point(0.05*i, 0.05*i)), diff --git a/src/test/regress/sql/spgist.sql b/src/test/regress/sql/spgist.sql index 7644f344a9..f375025dcb 100644 --- a/src/test/regress/sql/spgist.sql +++ b/src/test/regress/sql/spgist.sql @@ -34,7 +34,7 @@ vacuum spgist_point_tbl; -- use box and && rather than point, so that rescan happens when the -- traverse stack is non-empty -create table spgist_box_tbl(id serial, b box); +create unlogged table spgist_box_tbl(id serial, b box); insert into spgist_box_tbl(b) select box(point(i,j),point(i+s,j+s)) from generate_series(1,100,5) i, -- 2.39.5