Fix incorrect uses of Datum conversion macros
authorPeter Eisentraut <peter@eisentraut.org>
Sun, 28 Aug 2022 08:47:10 +0000 (10:47 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 5 Sep 2022 11:30:44 +0000 (13:30 +0200)
commit6bcda4a72123c3aa29fa3f03d952095675ad4468
treeccd9c5998367bb93509fce2a5c8c6bd49563f168
parent6dc0738812c3fdbd733d917267a0543ab5fdf997
Fix incorrect uses of Datum conversion macros

Since these macros just cast whatever you give them to the designated
output type, and many normal uses also cast the output type further, a
number of incorrect uses go undiscovered.  The fixes in this patch
have been discovered by changing these macros to inline functions,
which is the subject of a future patch.

Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com
22 files changed:
contrib/btree_gist/btree_utils_num.c
contrib/dblink/dblink.c
contrib/hstore/hstore_op.c
contrib/pageinspect/heapfuncs.c
src/backend/access/brin/brin_bloom.c
src/backend/access/brin/brin_minmax_multi.c
src/backend/access/common/toast_compression.c
src/backend/access/table/toast_helper.c
src/backend/access/transam/xlogfuncs.c
src/backend/statistics/mcv.c
src/backend/utils/adt/amutils.c
src/backend/utils/adt/multirangetypes.c
src/backend/utils/adt/pg_lsn.c
src/backend/utils/adt/pgstatfuncs.c
src/backend/utils/adt/rangetypes_spgist.c
src/backend/utils/adt/regexp.c
src/backend/utils/adt/tsgistidx.c
src/backend/utils/adt/tsquery_op.c
src/backend/utils/adt/varlena.c
src/backend/utils/adt/xml.c
src/backend/utils/resowner/resowner.c
src/pl/plperl/plperl.c