pgbench: Remove now-dead CState->ecnt
authorMichael Paquier <michael@paquier.xyz>
Sat, 27 Feb 2021 22:50:26 +0000 (07:50 +0900)
committerMichael Paquier <michael@paquier.xyz>
Sat, 27 Feb 2021 22:50:26 +0000 (07:50 +0900)
The last use of ecnt was in 12788ae.  It was getting incremented after a
backend error without any purpose since then, so let's get rid of it.

Author: Kota Miyake
Reviewed-by: Álvaro Herrera
Discussion: https://postgr.es/m/786c3d9fbe067763d899e78c296f9f0f@oss.nttdata.com

src/bin/pgbench/pgbench.c

index 627a244fb738bcb02665cf663e20d6f610241ed9..31a4df45f579c5af15f3eb0d3dfcaf762370a805 100644 (file)
@@ -427,7 +427,6 @@ typedef struct
 
        /* per client collected stats */
        int64           cnt;                    /* client transaction count, for -t */
-       int                     ecnt;                   /* error count */
 } CState;
 
 /*
@@ -2716,7 +2715,6 @@ sendCommand(CState *st, Command *command)
        if (r == 0)
        {
                pg_log_debug("client %d could not send %s", st->id, command->argv[0]);
-               st->ecnt++;
                return false;
        }
        else
@@ -2828,14 +2826,12 @@ readCommandResponse(CState *st, MetaCommand meta, char *varprefix)
        if (qrynum == 0)
        {
                pg_log_error("client %d command %d: no results", st->id, st->command);
-               st->ecnt++;
                return false;
        }
 
        return true;
 
 error:
-       st->ecnt++;
        PQclear(res);
        PQclear(next_res);
        do