Fixes:

Here's a couple more small fixes that I've made to make my runtime
checker happy with the code.  More along the lines of those that
I sent in the past, ie, a pointer to an array != the name of
an array.  The last patch is that I mailed about yesterday -- I got
two replies of "do it", so it's done.  As far as I can tell, however,
the function in question is never called by pg95, so either way
it can't hurt...

From:  "Kurt J. Lidl" <lidl@va.pubnix.com>

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index b04010bf95b05158fa35148ddddc10367e19d9f7..d950ee86803f720fca1fead6609c32b98b1b7591 100644 (file)
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/catalog/index.c,v 1.1.1.1 1996/07/09 06:21:15 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/catalog/index.c,v 1.2 1996/08/19 13:32:07 scrappy Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -992,7 +992,7 @@ index_create(char *heapRelationName,
             AttrNumber attNums[],
             Oid classObjectId[],
             uint16 parameterCount,
-            Datum parameter[],
+            Datum *parameter,
             Node *predicate)
 {
     Relation           heapRelation;
@@ -1610,7 +1610,7 @@ index_build(Relation heapRelation,
            int numberOfAttributes,
            AttrNumber attributeNumber[],
            uint16      parameterCount,
-           Datum       parameter[],
+           Datum       *parameter,
            FuncIndexInfo *funcInfo,
            PredInfo *predInfo)
 {

diff --git a/src/backend/catalog/index.h b/src/backend/catalog/index.h
index 1734f866a074d820ebe1a0ca64f44a9126b404c7..ef211ab951ce8c0b1d33ef0db08c1f7a4642ba50 100644 (file)
--- a/src/backend/catalog/index.h
+++ b/src/backend/catalog/index.h
@@ -6,7 +6,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- * $Id: index.h,v 1.1.1.1 1996/07/09 06:21:15 scrappy Exp $
+ * $Id: index.h,v 1.2 1996/08/19 13:32:08 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -36,7 +36,7 @@ extern void index_create(char *heapRelationName,
                         AttrNumber attNums[],
                         Oid classObjectId[], 
                         uint16 parameterCount,
-                        Datum parameter[], 
+                        Datum *parameter, 
                         Node *predicate);
 
 extern void index_destroy(Oid indexId);
@@ -53,7 +53,7 @@ extern void FillDummyExprContext(ExprContext *econtext, TupleTableSlot *slot,
 
 extern void index_build(Relation heapRelation, Relation indexRelation,
        int numberOfAttributes, AttrNumber attributeNumber[],
-       uint16 parameterCount, Datum parameter[], FuncIndexInfo *funcInfo,
+       uint16 parameterCount, Datum *parameter, FuncIndexInfo *funcInfo,
        PredInfo *predInfo);
 
 #endif /* INDEX_H */

diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c
index c04bf3627e694b5ac32712705e98beb67c612181..4f49138edfdcfed33d7d2a10c01f45ee9613137d 100644 (file)
--- a/src/backend/nodes/copyfuncs.c
+++ b/src/backend/nodes/copyfuncs.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.1.1.1 1996/07/09 06:21:32 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.2 1996/08/19 13:32:14 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -589,7 +589,7 @@ _copyResdom(Resdom *from)
 static Fjoin *
 _copyFjoin(Fjoin *from)
 {
-    Fjoin      *newnode;
+    Fjoin      *newnode = makeNode(Fjoin);
     
     /* ----------------
      * copy node superclass fields