Mention that resetting the timeout may be wrong on select retry.
authorBruce Momjian <bruce@momjian.us>
Mon, 14 Oct 2002 18:11:17 +0000 (18:11 +0000)
committerBruce Momjian <bruce@momjian.us>
Mon, 14 Oct 2002 18:11:17 +0000 (18:11 +0000)
src/interfaces/libpq/fe-misc.c

index 32b197bf6b6527e797b0a697e09e3cc887587747..7b5a2eeb15208c04c118f52743f8067d584b8e95 100644 (file)
@@ -25,7 +25,7 @@
  *
  *
  * IDENTIFICATION
- *   $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.82 2002/10/14 17:33:08 momjian Exp $
+ *   $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.83 2002/10/14 18:11:17 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -824,7 +824,12 @@ retry5:
        {
            /*
             *  select() may modify timeout argument on some platforms so
-            *  use copy
+            *  use copy.
+            *  XXX Do we really want to do that?  If select() returns
+            *  the number of seconds remaining, we are resetting
+            *  the timeout to its original value.  This will yeild
+            *  incorrect timings when select() is interrupted.
+            *  bjm 2002-10-14
             */
            tmp_timeout = *timeout;
            ptmp_timeout = &tmp_timeout;