Make the standby server promptly handle interrupt signals.
authorFujii Masao <fujii@postgresql.org>
Mon, 16 Nov 2020 09:27:51 +0000 (18:27 +0900)
committerFujii Masao <fujii@postgresql.org>
Mon, 16 Nov 2020 09:27:51 +0000 (18:27 +0900)
This commit changes the startup process in the standby server so that
it handles the interrupt signals after waiting for wal_retrieve_retry_interval
on the latch and resetting it, before entering another wait on the latch.
This change causes the standby server to promptly handle interrupt signals.

Otherwise, previously, there was the case where the standby needs to
wait extra five seconds to shutdown when the shutdown request arrived
while the startup process was waiting for wal_retrieve_retry_interval
on the latch.

Author: Fujii Masao, but implementation idea is from Soumyadeep Chakraborty
Reviewed-by: Soumyadeep Chakraborty
Discussion: https://postgr.es/m/9d7e6ab0-8a53-ddb9-63cd-289bcb25fe0e@oss.nttdata.com

src/backend/access/transam/xlog.c

index aa63f376159d35658b11026af7fa09cd512ff72e..7d97b96e728c0ed7cdc00e86a9e857ba1867bffe 100644 (file)
@@ -12225,6 +12225,9 @@ WaitForWALToBecomeAvailable(XLogRecPtr RecPtr, bool randAccess,
                                         WAIT_EVENT_RECOVERY_RETRIEVE_RETRY_INTERVAL);
                        ResetLatch(MyLatch);
                        now = GetCurrentTimestamp();
+
+                       /* Handle interrupt signals of startup process */
+                       HandleStartupProcInterrupts();
                    }
                    last_fail_time = now;
                    currentSource = XLOG_FROM_ARCHIVE;