Remove pstrdup of TextDatumGetCString

The result of TextDatumGetCString is already palloc'ed.

diff --git a/src/backend/catalog/pg_subscription.c b/src/backend/catalog/pg_subscription.c
index f5ba9f6d13c9a6f3995c943788574811359bc550..7e38b1a31cdf4c30158850e46ef2105188aa3c18 100644 (file)
--- a/src/backend/catalog/pg_subscription.c
+++ b/src/backend/catalog/pg_subscription.c
@@ -75,7 +75,7 @@ GetSubscription(Oid subid, bool missing_ok)
                            Anum_pg_subscription_subconninfo,
                            &isnull);
    Assert(!isnull);
-   sub->conninfo = pstrdup(TextDatumGetCString(datum));
+   sub->conninfo = TextDatumGetCString(datum);
 
    /* Get slotname */
    datum = SysCacheGetAttr(SUBSCRIPTIONOID,
@@ -207,7 +207,7 @@ textarray_to_stringlist(ArrayType *textarray)
        return NIL;
 
    for (i = 0; i < nelems; i++)
-       res = lappend(res, makeString(pstrdup(TextDatumGetCString(elems[i]))));
+       res = lappend(res, makeString(TextDatumGetCString(elems[i])));
 
    return res;
 }

diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
index 5bf8d937c9b8c8670921dd5466e8d43f7be9b4d2..7b8b11cb81f14af3fa0e758e345256e9c66c0d84 100644 (file)
--- a/src/backend/commands/subscriptioncmds.c
+++ b/src/backend/commands/subscriptioncmds.c
@@ -767,7 +767,7 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel)
    datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup,
                            Anum_pg_subscription_subconninfo, &isnull);
    Assert(!isnull);
-   conninfo = pstrdup(TextDatumGetCString(datum));
+   conninfo = TextDatumGetCString(datum);
 
    /* Get slotname */
    datum = SysCacheGetAttr(SUBSCRIPTIONOID, tup,

diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c
index d1f27348f063c84f940fc6603d255940f75f4565..bf276410099587345a0eaa96e35b2c19677a9835 100644 (file)
--- a/src/backend/replication/logical/tablesync.c
+++ b/src/backend/replication/logical/tablesync.c
@@ -612,7 +612,7 @@ fetch_remote_table_info(char *nspname, char *relname,
    while (tuplestore_gettupleslot(res->tuplestore, true, false, slot))
    {
        lrel->attnames[natt] =
-           pstrdup(TextDatumGetCString(slot_getattr(slot, 1, &isnull)));
+           TextDatumGetCString(slot_getattr(slot, 1, &isnull));
        Assert(!isnull);
        lrel->atttyps[natt] = DatumGetObjectId(slot_getattr(slot, 2, &isnull));
        Assert(!isnull);