Fix coverity complaint about commit 40d964ec99.
authorAmit Kapila <akapila@postgresql.org>
Wed, 1 Apr 2020 03:58:13 +0000 (09:28 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 1 Apr 2020 03:58:13 +0000 (09:28 +0530)
The coverity complained that dividing integer expressions and then
converting the integer quotient to type "double" would lose fractional
part.  Typecasting one of the arguments of expression with double should
fix the report.

Author: Mahendra Singh Thalor
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/20200329224818.6phnhv7o2q2rfovf@alap3.anarazel.de

src/backend/commands/vacuum.c

index 59731d687f6a76d23daae13407476526b9678ceb..3a89f8fe1e2eefac3c656eabb15bf1e5f8854e7c 100644 (file)
@@ -2077,7 +2077,7 @@ compute_parallel_delay(void)
        VacuumCostBalanceLocal += VacuumCostBalance;
 
        if ((shared_balance >= VacuumCostLimit) &&
-               (VacuumCostBalanceLocal > 0.5 * (VacuumCostLimit / nworkers)))
+               (VacuumCostBalanceLocal > 0.5 * ((double) VacuumCostLimit / nworkers)))
        {
                /* Compute sleep time based on the local cost balance */
                msec = VacuumCostDelay * VacuumCostBalanceLocal / VacuumCostLimit;