Fix C++ compile failures in headers.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Jan 2019 19:07:01 +0000 (14:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Jan 2019 19:07:01 +0000 (14:07 -0500)
commiteaf0380eccd53df5ce7d1fed41f4ca16f4146408
treeb23d9a102a19074bc2b0faedeacbaccb29864c1c
parenta968d54c5df196e06305c1efa731657f9536ec7a
Fix C++ compile failures in headers.

Avoid using "typeid" as a parameter name in header files, since that
is a C++ keyword.  These cases were introduced recently, in 04fe805a1
and 586b98fdf.

Since I'm an incurable neatnik, also rename these parameters in the
underlying function definitions.  That's not really necessary per
project rules, but I don't like function declarations that don't
quite agree with the underlying definitions.

Per src/tools/pginclude/cpluspluscheck.
src/backend/optimizer/plan/setrefs.c
src/backend/utils/adt/varlena.c
src/include/optimizer/planmain.h
src/include/utils/varlena.h