Reset btpo_cycleid in nbtree VACUUM's REDO routine.
authorPeter Geoghegan <pg@bowt.ie>
Mon, 23 Dec 2024 20:46:00 +0000 (15:46 -0500)
committerPeter Geoghegan <pg@bowt.ie>
Mon, 23 Dec 2024 20:46:00 +0000 (15:46 -0500)
commitda9517fb3a0979f8d75823199f7a231e0269963b
tree005af1e2dec47d60c133fd9098867045da858ad3
parentc431986de16cc7e7af8ba3af45d846f279606fd3
Reset btpo_cycleid in nbtree VACUUM's REDO routine.

Reset btpo_cycleid to 0 in btree_xlog_vacuum for consistency with
_bt_delitems_vacuum (the corresponding original execution code).  This
makes things neater.

There might be some performance benefit to being consistent like this.
When btvacuumpage doesn't call _bt_delitems_vacuum, it can still
proactively reset btpo_cycleid to 0 via a separate hint-like update
mechanism (it does so whenever it sees that it isn't already set to 0).
And so it's possible that being consistent about resetting btpo_cycleid
like this will save work later on, after standby promotion: subsequent
VACUUMs won't need to clear btpo_cycleid using the hint-like update
mechanism as often as they otherwise would.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/CAH2-Wz=+LDFxn9NZyEsCo8ifcyKt6+n-VLyygySEHgMz+oynqw@mail.gmail.com
src/backend/access/nbtree/nbtxlog.c