Rename wal_keep_segments to wal_keep_size.
authorFujii Masao <fujii@postgresql.org>
Mon, 20 Jul 2020 04:30:18 +0000 (13:30 +0900)
committerFujii Masao <fujii@postgresql.org>
Mon, 20 Jul 2020 04:30:18 +0000 (13:30 +0900)
commitc3fe108c025e4a080315562d4c15ecbe3f00405e
treeb70e9db2e58fedb9abd6506574629f1e5ca75386
parent0bead9af484c1d0a67e690fda47011addaa5bc9d
Rename wal_keep_segments to wal_keep_size.

max_slot_wal_keep_size that was added in v13 and wal_keep_segments are
the GUC parameters to specify how much WAL files to retain for
the standby servers. While max_slot_wal_keep_size accepts the number of
bytes of WAL files, wal_keep_segments accepts the number of WAL files.
This difference of setting units between those similar parameters could
be confusing to users.

To alleviate this situation, this commit renames wal_keep_segments to
wal_keep_size, and make users specify the WAL size in it instead of
the number of WAL files.

There was also the idea to rename max_slot_wal_keep_size to
max_slot_wal_keep_segments, in the discussion. But we have been moving
away from measuring in segments, for example, checkpoint_segments was
replaced by max_wal_size. So we concluded to rename wal_keep_segments
to wal_keep_size.

Back-patch to v13 where max_slot_wal_keep_size was added.

Author: Fujii Masao
Reviewed-by: Álvaro Herrera, Kyotaro Horiguchi, David Steele
Discussion: https://postgr.es/m/574b4ea3-e0f9-b175-ead2-ebea7faea855@oss.nttdata.com
12 files changed:
doc/src/sgml/catalogs.sgml
doc/src/sgml/config.sgml
doc/src/sgml/high-availability.sgml
doc/src/sgml/ref/pg_basebackup.sgml
doc/src/sgml/wal.sgml
src/backend/access/transam/xlog.c
src/backend/replication/slotfuncs.c
src/backend/utils/misc/guc.c
src/backend/utils/misc/postgresql.conf.sample
src/bin/pg_rewind/t/RewindTest.pm
src/include/access/xlog.h
src/test/recovery/t/019_replslot_limit.pl