pg_stat_activity: show NULL stmt start time for walsenders
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
commitb175bd59fa54a90d21bc541f812643ac45281b98
tree669efcda3700708d0db86e4d7b372438d7873285
parentce242ae154dde3217971c6f262705d80999f4e00
pg_stat_activity: show NULL stmt start time for walsenders

Returning a non-NULL time is pointless, sinc a walsender is not a
process that would be running normal transactions anyway, but the code
was unintentionally exposing the process start time intermittently,
which was not only bogus but it also confused monitoring systems looking
for idle transactions.  Fix by avoiding all updates in walsenders.

Backpatch to 11, where walsenders started appearing in pg_stat_activity.

Reported-by: Tomas Vondra
Discussion: https://postgr.es/m/20191209234409.exe7osmyalwkt5j4@development
src/backend/access/transam/xact.c