From 4d373e05286daff05d7fd0f6e4ab7ff4e5304d81 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Tue, 15 Feb 2022 11:35:17 +0100 Subject: [PATCH] Ensure that STDERR is empty in connect_ok tests Connections performed via connect_ok() in TAP tests should not write anything to STDERR. Author: Jacob Champion Reviewed-by: Tom Lane Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/9D4FFB61-392B-4A2C-B7E4-911797B4AC14@yesql.se Discussion: https://postgr.es/m/ec146256e31afa0542f9fa970ec258c5f1a5f98.camel@vmware.com --- src/test/perl/PostgreSQL/Test/Cluster.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm index 41beadff9d..ed70eff374 100644 --- a/src/test/perl/PostgreSQL/Test/Cluster.pm +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm @@ -2214,8 +2214,11 @@ sub connect_ok if (defined($params{expected_stdout})) { - like($stdout, $params{expected_stdout}, "$test_name: matches"); + like($stdout, $params{expected_stdout}, "$test_name: stdout matches"); } + + is($stderr, "", "$test_name: no stderr"); + if (@log_like or @log_unlike) { my $log_contents = PostgreSQL::Test::Utils::slurp_file($self->logfile, $log_location); -- 2.39.5