From 381c48a49d469b1a94f9d5bf59ede6a35e752af9 Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Wed, 4 Feb 2015 18:35:27 +0100 Subject: [PATCH] Fix sending of comment/review emails Without using .as_string() on a message, the default is to generate a string including the envelope header used in a unix mbox. This would of course generate completely broken messages when passed to smtp. --- pgcommitfest/commitfest/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pgcommitfest/commitfest/views.py b/pgcommitfest/commitfest/views.py index a57000a..b11ee88 100644 --- a/pgcommitfest/commitfest/views.py +++ b/pgcommitfest/commitfest/views.py @@ -345,7 +345,7 @@ def comment(request, cfid, patchid, what): msg['References'] = '<%s> <%s>' % (form.thread.messageid, form.respid) msg['Message-ID'] = make_msgid('pgcf') - send_mail(UserWrapper(request.user).email, settings.HACKERS_EMAIL, msg) + send_mail(UserWrapper(request.user).email, settings.HACKERS_EMAIL, msg.as_string()) PatchHistory(patch=patch, by=request.user, what='Posted %s with messageid %s' % (what, msg['Message-ID'])).save() -- 2.39.5