From 20227781555cf6698ea6d1ad24ec6cc7b1aed15d Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 17 Sep 2009 21:15:18 +0000 Subject: [PATCH] Improve wording of error message when a postgresql.conf setting is ignored because it can only be set at server start. In particular, hiding the main reason in the detail message was suboptimal. --- src/backend/utils/misc/guc-file.l | 5 ++--- src/backend/utils/misc/guc.c | 10 ++++------ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l index b1ff03666a..57c8686823 100644 --- a/src/backend/utils/misc/guc-file.l +++ b/src/backend/utils/misc/guc-file.l @@ -260,9 +260,8 @@ ProcessConfigFile(GucContext context) { ereport(elevel, (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), - errmsg("attempted change of parameter \"%s\" ignored", - gconf->name), - errdetail("This parameter cannot be changed after server start."))); + errmsg("parameter \"%s\" cannot be changed without restarting the server", + gconf->name))); continue; } diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 2224d5683d..33b1f8b389 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4599,18 +4599,16 @@ set_config_option(const char *name, const char *value, if (changeVal && !is_newvalue_equal(record, value)) ereport(elevel, (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), - errmsg("attempted change of parameter \"%s\" ignored", - name), - errdetail("This parameter cannot be changed after server start."))); + errmsg("parameter \"%s\" cannot be changed without restarting the server", + name))); return true; } if (context != PGC_POSTMASTER) { ereport(elevel, (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), - errmsg("attempted change of parameter \"%s\" ignored", - name), - errdetail("This parameter cannot be changed after server start."))); + errmsg("parameter \"%s\" cannot be changed without restarting the server", + name))); return false; } break; -- 2.39.5