Make RelationFlushRelation() work without ResourceOwner during abort
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 6 Jun 2024 15:56:28 +0000 (18:56 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 6 Jun 2024 15:56:28 +0000 (18:56 +0300)
commite6cd85772647099563da5ada53bd6ab7d096ce00
treeb0f9135f14ac914e5d2621b37ce052896f4e6413
parent505c008ca37c4f6f2fffcde370b5d8354c4d4dc3
Make RelationFlushRelation() work without ResourceOwner during abort

ReorderBufferImmediateInvalidation() executes invalidation messages in
an aborted transaction. However, RelationFlushRelation sometimes
required a valid resource owner, to temporarily increment the refcount
of the relache entry. Commit b8bff07daa worked around that in the main
subtransaction abort function, AbortSubTransaction(), but missed this
similar case in ReorderBufferImmediateInvalidation().

To fix, introduce a separate function to invalidate a relcache
entry. It does the same thing as RelationClearRelation(rebuild==true)
does when outside a transaction, but can be called without
incrementing the refcount.

Add regression test. Before this fix, it failed with:

ERROR: ResourceOwnerEnlarge called after release started

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://www.postgresql.org/message-id/e56be7d9-14b1-664d-0bfc-00ce9772721c@gmail.com
contrib/test_decoding/expected/decoding_in_xact.out
contrib/test_decoding/sql/decoding_in_xact.sql
src/backend/access/transam/xact.c
src/backend/utils/cache/relcache.c