Harmonize lexer adjacent function parameter names.
authorPeter Geoghegan <pg@bowt.ie>
Wed, 21 Sep 2022 20:21:36 +0000 (13:21 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Wed, 21 Sep 2022 20:21:36 +0000 (13:21 -0700)
commitaab06442d488364f8861219cb8864a16b6d0d4e4
treec6a42bd9e8935409d0d43966834e32314e90861f
parente59a67fb8fe1ac1408dc1858038f525a860d772b
Harmonize lexer adjacent function parameter names.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions for several "lexer
adjacent" backend functions.

These functions were missed by recent commits because they were obscured
by clang-tidy warnings about functions whose signature is directly under
the control of the lexer (flex seems to always generate function
declarations with unnamed parameters).  We probably can't fix most of
the warnings it generates for translation units that get built from .l
and .y files, but we can at least do this much.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com
src/bin/pgbench/exprparse.y
src/include/replication/syncrep.h
src/include/replication/walsender_private.h