Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Aug 2019 21:02:52 +0000 (17:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Aug 2019 21:02:52 +0000 (17:02 -0400)
If a test case tried to set an invalid value of synchronous_standby_names,
the test script didn't detect that, which seems like a bad idea.
Noticed while testing a proposed patch that broke some of these
test cases.

src/test/recovery/t/007_sync_rep.pl

index eccde8f551f059f66839ff1072c8d6cad044f1d9..05803bed4e379bfddc5e3327daac309d723f90fb 100644 (file)
@@ -18,7 +18,7 @@ sub test_sync_state
 
    if (defined($setting))
    {
-       $self->psql('postgres',
+       $self->safe_psql('postgres',
            "ALTER SYSTEM SET synchronous_standby_names = '$setting';");
        $self->reload;
    }