Remove useless variable.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Mar 2022 19:05:22 +0000 (15:05 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Mar 2022 19:05:22 +0000 (15:05 -0400)
flatten_join_alias_vars_mutator counted attnums, but didn't
do anything with the count (no doubt it did at one time).

Noted by buildfarm member seawasp.

src/backend/optimizer/util/var.c

index 2b44ef3e1769ce7b8df9e903997d4151aefc499c..6d11d187a0c4bf93334c3ce81eb911f7b7149289 100644 (file)
@@ -774,16 +774,13 @@ flatten_join_alias_vars_mutator(Node *node,
                        RowExpr    *rowexpr;
                        List       *fields = NIL;
                        List       *colnames = NIL;
-                       AttrNumber      attnum;
                        ListCell   *lv;
                        ListCell   *ln;
 
-                       attnum = 0;
                        Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames));
                        forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames)
                        {
                                newvar = (Node *) lfirst(lv);
-                               attnum++;
                                /* Ignore dropped columns */
                                if (newvar == NULL)
                                        continue;