pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid

Commit 6df7a9698 wrote appendPQExpBuffer where it should have
written printfPQExpBuffer.  This resulted in re-issuing the
previous query along with the desired one, which very accidentally
had no negative consequences except for some wasted cycles.

Back-patch to v14 where that came in.

Discussion: https://postgr.es/m/1714711.1642962663@sss.pgh.pa.us

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 7c0e396ce13cebdfde9b79214e2a89b6f90b642b..f1e8b0b5c2cca2639dac67e897222ffe24a8c961 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -4574,7 +4574,7 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout,
        {
                if (fout->remoteVersion >= 140000)
                {
-                       appendPQExpBuffer(upgrade_query,
+                       printfPQExpBuffer(upgrade_query,
                                                          "SELECT t.oid, t.typarray "
                                                          "FROM pg_catalog.pg_type t "
                                                          "JOIN pg_catalog.pg_range r "