Remove redundant variable

Author: Amul Sul <sulamul@gmail.com>
Reviewed-by: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://postgr.es/m/CAAJ_b94HaNcrPVREUuB9-qUn2uB+gfcoX3FG_Vx0S6aFse+yhw@mail.gmail.com

diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index 9dd30370dae178d9f8b7cbec8e294e249f37aea4..6fae9a96872020afcdece5cf83c27f4b6974600b 100644 (file)
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -176,7 +176,6 @@ transformCreateStmt(CreateStmt *stmt, const char *queryString)
    Oid         namespaceid;
    Oid         existing_relid;
    ParseCallbackState pcbstate;
-   bool        is_foreign_table = IsA(stmt, CreateForeignTableStmt);
 
    /*
     * We must not scribble on the passed-in CreateStmt, so copy it.  (This is
@@ -333,8 +332,11 @@ transformCreateStmt(CreateStmt *stmt, const char *queryString)
 
    /*
     * Postprocess check constraints.
+    *
+    * For regular tables all constraints can be marked valid immediately,
+    * because the table is new therefore empty. Not so for foreign tables.
     */
-   transformCheckConstraints(&cxt, !is_foreign_table ? true : false);
+   transformCheckConstraints(&cxt, !cxt.isforeign);
 
    /*
     * Postprocess extended statistics.