Remove redundant HandleWalWriterInterrupts().
authorFujii Masao <fujii@postgresql.org>
Thu, 25 Jan 2024 03:50:08 +0000 (12:50 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 25 Jan 2024 03:50:08 +0000 (12:50 +0900)
Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
became the same as HandleMainLoopInterrupts(). So this commit removes
HandleWalWriterInterrupts() and makes walwriter use
HandleMainLoopInterrupts() for improved code simplicity.

Author: Fujii Masao
Reviewed-by: Bharath Rupireddy, Nathan Bossart
Discussion: https://postgr.es/m/CAHGQGwHUtwCsB4DnqFLiMiVzjcA=zmeCKf9_pgQM-yJopydatw@mail.gmail.com

src/backend/postmaster/walwriter.c

index 177b1837c269c7f4f66151309dee220254e6d85e..75c9f8707b719bcb664895a7b9749d78c1cb22e1 100644 (file)
@@ -78,9 +78,6 @@ int                   WalWriterFlushAfter = DEFAULT_WAL_WRITER_FLUSH_AFTER;
 #define LOOPS_UNTIL_HIBERNATE          50
 #define HIBERNATE_FACTOR                       25
 
-/* Prototypes for private functions */
-static void HandleWalWriterInterrupts(void);
-
 /*
  * Main entry point for walwriter process
  *
@@ -245,7 +242,7 @@ WalWriterMain(void)
                ResetLatch(MyLatch);
 
                /* Process any signals received recently */
-               HandleWalWriterInterrupts();
+               HandleMainLoopInterrupts();
 
                /*
                 * Do what we're here for; then, if XLogBackgroundFlush() found useful
@@ -275,26 +272,3 @@ WalWriterMain(void)
                                                 WAIT_EVENT_WAL_WRITER_MAIN);
        }
 }
-
-/*
- * Interrupt handler for main loops of WAL writer process.
- */
-static void
-HandleWalWriterInterrupts(void)
-{
-       if (ProcSignalBarrierPending)
-               ProcessProcSignalBarrier();
-
-       if (ConfigReloadPending)
-       {
-               ConfigReloadPending = false;
-               ProcessConfigFile(PGC_SIGHUP);
-       }
-
-       if (ShutdownRequestPending)
-               proc_exit(0);
-
-       /* Perform logging of memory contexts of this process */
-       if (LogMemoryContextPending)
-               ProcessLogMemoryContextInterrupt();
-}