Don't delay replication for less than recovery_min_apply_delay's resolution.

Recovery delays are implemented by waiting on a latch, and latches take
milliseconds as a parameter. The required amount of waiting was computed
using microsecond resolution though and the wait loop's abort condition
was checking the delay in microseconds as well.  This could lead to
short spurts of busy looping when the overall wait time was below a
millisecond, but above 0 microseconds.

Instead just formulate the wait loop's abort condition in millisecond
granularity as well. Given that that's recovery_min_apply_delay
resolution, it seems harmless to not wait for less than a millisecond.

Backpatch to 9.4 where recovery_min_apply_delay was introduced.

Discussion: 20150323141819.GH26995@alap3.anarazel.de

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index bc8363b4c769b9ac365b2df12fe15cb55d15b0c8..2c6ae12b8d6bc62c4601670ae28f1899efaa801b 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -5572,7 +5572,8 @@ recoveryApplyDelay(XLogReaderState *record)
                TimestampDifference(GetCurrentTimestamp(), recoveryDelayUntilTime,
                                                        &secs, &microsecs);
 
-               if (secs <= 0 && microsecs <= 0)
+               /* NB: We're ignoring waits below min_apply_delay's resolution. */
+               if (secs <= 0 && microsecs / 1000 <= 0)
                        break;
 
                elog(DEBUG2, "recovery apply delay %ld seconds, %d milliseconds",