Fix oversight in data-type change for autovacuum_vacuum_cost_delay.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 26 Mar 2019 17:32:30 +0000 (13:32 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 26 Mar 2019 17:32:38 +0000 (13:32 -0400)
Commit caf626b2c missed that the relevant reloptions entry needs
to be moved from the intRelOpts[] array to realRelOpts[].
Somewhat surprisingly, it seems to work anyway, perhaps because
the desired default and limit values are all integers.  We ought
to have either a simpler data structure or better cross-checking
here, but that's for another patch.

Nikolay Shaplov

Discussion: https://postgr.es/m/4861742.12LTaSB3sv@x200m

src/backend/access/common/reloptions.c

index 3b0b138f247c1f75dacd2c003b9bd9f56581c086..b58a1f7a729715d26e37e88dd8d92ea45e721bc5 100644 (file)
@@ -212,15 +212,6 @@ static relopt_int intRelOpts[] =
        },
        -1, 0, INT_MAX
    },
-   {
-       {
-           "autovacuum_vacuum_cost_delay",
-           "Vacuum cost delay in milliseconds, for autovacuum",
-           RELOPT_KIND_HEAP | RELOPT_KIND_TOAST,
-           ShareUpdateExclusiveLock
-       },
-       -1, 0, 100
-   },
    {
        {
            "autovacuum_vacuum_cost_limit",
@@ -346,6 +337,15 @@ static relopt_int intRelOpts[] =
 
 static relopt_real realRelOpts[] =
 {
+   {
+       {
+           "autovacuum_vacuum_cost_delay",
+           "Vacuum cost delay in milliseconds, for autovacuum",
+           RELOPT_KIND_HEAP | RELOPT_KIND_TOAST,
+           ShareUpdateExclusiveLock
+       },
+       -1, 0.0, 100.0
+   },
    {
        {
            "autovacuum_vacuum_scale_factor",