Remove unnecessary clauses_attnums variable

Commit c676e659b2 reworked how choose_best_statistics() picks the best
extended statistics, but failed to remove clauses_attnums which is now
unnecessary. So get rid of it and backpatch to 12, same as c676e659b2.

Author: Tomas Vondra
Discussion: https://postgr.es/m/CA+u7OA7H5rcE2=8f263w4NZD6ipO_XOrYB816nuLXbmSTH9pQQ@mail.gmail.com
Backpatch-through: 12

diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 6299011ca66d0b2ca817c4ed5f7a1d22dbb5dfaa..9d339433f65a34f5a71f3bde2ae3ac4292b4fad9 100644 (file)
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -1206,7 +1206,6 @@ statext_mcv_clauselist_selectivity(PlannerInfo *root, List *clauses, int varReli
                                                                   RelOptInfo *rel, Bitmapset **estimatedclauses)
 {
        ListCell   *l;
-       Bitmapset  *clauses_attnums = NULL;
        Bitmapset **list_attnums;
        int                     listidx;
        StatisticExtInfo *stat;
@@ -1244,10 +1243,7 @@ statext_mcv_clauselist_selectivity(PlannerInfo *root, List *clauses, int varReli
 
                if (!bms_is_member(listidx, *estimatedclauses) &&
                        statext_is_compatible_clause(root, clause, rel->relid, &attnums))
-               {
                        list_attnums[listidx] = attnums;
-                       clauses_attnums = bms_add_members(clauses_attnums, attnums);
-               }
                else
                        list_attnums[listidx] = NULL;