Suggestions from Brendan Jurd.

- Increase default text field size from 40 to 60 and default max size
from 40 to 120.
- Change secondary sort on commitfest_view page to id.

diff --git a/perl-lib/PgCommitFest/CommitFest.pm b/perl-lib/PgCommitFest/CommitFest.pm
index b1b3d8ddc76671654fc6087a43ffcb4370a6b6b4..06c725a69963968cb7971e2f77422dc9dc123761 100644 (file)
--- a/perl-lib/PgCommitFest/CommitFest.pm
+++ b/perl-lib/PgCommitFest/CommitFest.pm
@@ -103,7 +103,7 @@ EOM
 SELECT id, name, patch_status_id, patch_status, author, reviewers,
        commitfest_topic_id, commitfest_topic, commitfest_id, date_closed
 FROM patch_view WHERE commitfest_id = ?
-       ORDER BY date_closed, commitfest_topic, name
+       ORDER BY date_closed, commitfest_topic, id
 EOM
        for my $p (@$patch_list) {
                if (grep { $_ eq $p->{'patch_status_id'} } qw(4 5 6)) {

diff --git a/perl-lib/PgCommitFest/WebControl.pm b/perl-lib/PgCommitFest/WebControl.pm
index 7f4e48fbe348e02f0e0656da601b07f13e6d458c..6873dcbe408b034acd72c808ada8f7d4192810df 100644 (file)
--- a/perl-lib/PgCommitFest/WebControl.pm
+++ b/perl-lib/PgCommitFest/WebControl.pm
@@ -132,9 +132,9 @@ sub render {
                        $self->{'name'},
                        $self->{'istype'}{'password'} ? 'password' : 'text',
                        defined $self->{'size'} ? $self->{'size'}
-                               : ($self->{'istype'}{'date'} ? 10 : 40),
+                               : ($self->{'istype'}{'date'} ? 10 : 60),
                        defined $self->{'maxlength'} ? $self->{'maxlength'}
-                               : ($self->{'istype'}{'date'} ? 10 : 40),
+                               : ($self->{'istype'}{'date'} ? 10 : 120),
                        $self->{'istype'}{'password'} ? '' : escape($self->{'value'});
        }
        elsif ($self->{'istype'}{'textarea'}) {