Fix sending of comment/review emails

Without using .as_string() on a message, the default is to generate
a string including the envelope header used in a unix mbox. This would
of course generate completely broken messages when passed to smtp.

diff --git a/pgcommitfest/commitfest/views.py b/pgcommitfest/commitfest/views.py
index a57000ae34b6d1d822e9aae985b50667e6034835..b11ee88db7adb8ae9b6fb70c0abf7031e84c51a6 100644 (file)
--- a/pgcommitfest/commitfest/views.py
+++ b/pgcommitfest/commitfest/views.py
@@ -345,7 +345,7 @@ def comment(request, cfid, patchid, what):
                        msg['References'] = '<%s> <%s>' % (form.thread.messageid, form.respid)
                        msg['Message-ID'] = make_msgid('pgcf')
 
-                       send_mail(UserWrapper(request.user).email, settings.HACKERS_EMAIL, msg)
+                       send_mail(UserWrapper(request.user).email, settings.HACKERS_EMAIL, msg.as_string())
 
                        PatchHistory(patch=patch, by=request.user, what='Posted %s with messageid %s' % (what, msg['Message-ID'])).save()