Fix some pg_verifybackup issues reported by Coverity.
authorRobert Haas <rhaas@postgresql.org>
Tue, 1 Oct 2024 12:31:33 +0000 (08:31 -0400)
committerRobert Haas <rhaas@postgresql.org>
Tue, 1 Oct 2024 12:36:54 +0000 (08:36 -0400)
commitfc1b2ce0ee9c9745c5c562b692e021344a3f719a
tree41c4cb8e62e734e999aa485259e2b4fba9fcfe96
parent9c2a6c5a5f4b94a93120009e623ae8bd153e6dbb
Fix some pg_verifybackup issues reported by Coverity.

Commit 8dfd3129027969fdd2d9d294220c867d2efd84aa introduced a few
problems. verify_tar_file() forgot to free a buffer; the leak can't
add up to anything material, but might as well fix it.
precheck_tar_backup_file() intended to return after reporting an
error but didn't actually do so. member_copy_control_data() could
try to copy zero bytes (and maybe Coverity thinks it can even be
trying to copy a negative number of bytes).

Per discussion with Tom Lane.

Discussion: http://postgr.es/m/1240823.1727629418@sss.pgh.pa.us
src/bin/pg_verifybackup/astreamer_verify.c
src/bin/pg_verifybackup/pg_verifybackup.c