Remove obsolete restriction on the range of log_rotation_size.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Jan 2025 19:36:56 +0000 (14:36 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Jan 2025 19:36:56 +0000 (14:36 -0500)
commitd4c3a6b8ad830882066122081a7141ecd573f45d
treea007761cdcd4093198d3f2f473da2344e61af261
parent041e8b95b8cd251bfec6a3c9c3dd6614de6a4c9b
Remove obsolete restriction on the range of log_rotation_size.

When syslogger.c was first written, we didn't want to assume that
all platforms have 64-bit ftello.  But we've been assuming that
since v13 (cf commit 799d22461), so let's use that in syslogger.c
and allow log_rotation_size to range up to INT_MAX kilobytes.

The old code effectively limited log_rotation_size to 2GB regardless
of platform.  While nobody's complained, that doesn't seem too far
away from what might be thought reasonable these days.

I noticed this while searching for instances of "1024L" in connection
with commit 041e8b95b.  These were the last such instances.
(We still have instances of L-suffixed literals, but most of them
are associated with wait intervals for pg_usleep or similar functions.
I don't see any urgent reason to change that.)
src/backend/postmaster/syslogger.c
src/backend/utils/misc/guc_tables.c