pg_receivexlog - Exit on failure to parse
authorStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 19:31:23 +0000 (15:31 -0400)
committerStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 19:31:23 +0000 (15:31 -0400)
commitd368a301b3a4bf5fec17e81c630adddeac80a7fc
tree99deb30d128b40387a3e96cef81700680588a633
parent234e4cf6e1eac2f0e514379a2a533ffb71b33732
pg_receivexlog - Exit on failure to parse

In streamutil.c:GetConnection(), upgrade failure to parse the
connection string to an exit(1) instead of simply returning NULL.
Most callers already immediately exited, but pg_receivexlog would
loop on this case, continually trying to re-parse the connection
string (which can't be changed after pg_receivexlog has started).

GetConnection() was already expected to exit(1) in some cases
(eg: failure to allocate memory or if unable to determine the
integer_datetimes flag), so this change shouldn't surprise anyone.

Began looking at this due to the Coverity scanner complaining that
we were leaking err_msg in this case- no longer an issue since we
just exit(1) immediately.
src/bin/pg_basebackup/streamutil.c