Remove promote_trigger_file.
authorThomas Munro <tmunro@postgresql.org>
Mon, 28 Nov 2022 22:28:08 +0000 (11:28 +1300)
committerThomas Munro <tmunro@postgresql.org>
Mon, 28 Nov 2022 23:08:38 +0000 (12:08 +1300)
commitcd4329d9393f84dce34f0bd2dd936adc8ffaa213
treebf98eba87f3bacb2694797b552cc914a0ef8ead2
parentf0cd57f852cb88a4252db175317ec4627ec1b1cd
Remove promote_trigger_file.

Previously, an idle startup (recovery) process would wake up every 5
seconds to have a chance to poll for promote_trigger_file, even if that
GUC was not configured.  That promotion triggering mechanism was
effectively superseded by pg_ctl promote and pg_promote() a long time
ago.  There probably aren't many users left and it's very easy to change
to the modern mechanisms, so we agreed to remove the feature.

This is part of a campaign to reduce wakeups on idle systems.

Author: Simon Riggs <simon.riggs@enterprisedb.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Ian Lawrence Barwick <barwick@gmail.com>
Discussion: https://postgr.es/m/CANbhV-FsjnzVOQGBpQ589%3DnWuL1Ex0Ykn74Nh1hEjp2usZSR5g%40mail.gmail.com
doc/src/sgml/appendix-obsolete-recovery-config.sgml
doc/src/sgml/config.sgml
doc/src/sgml/high-availability.sgml
src/backend/access/transam/xlogrecovery.c
src/backend/utils/misc/guc_tables.c
src/backend/utils/misc/postgresql.conf.sample
src/include/access/xlogrecovery.h