Relocate a badly placed Assert in COPY FROM code
authorDavid Rowley <drowley@postgresql.org>
Fri, 16 Aug 2024 22:36:23 +0000 (10:36 +1200)
committerDavid Rowley <drowley@postgresql.org>
Fri, 16 Aug 2024 22:36:23 +0000 (10:36 +1200)
commitbd8fe12ef3f727ed3658daf9b26beaf2b891e9bc
tree3345b562bb0dadd11c1d9ecd71993b0d862f8506
parent1d80d6b50e6401828fc445151375f9bde3f99ac6
Relocate a badly placed Assert in COPY FROM code

There's not much point in asserting a pointer isn't NULL after some code
has already dereferenced that pointer.

Adjust the code so that the Assert occurs before the pointer dereference.

The Assert probably has questionable value in the first place, but it
seems worth keeping around to document the contract between
CopyMultiInsertInfoNextFreeSlot() and its callers.

Author: Amul Sul <sulamul@gmail.com>
Discussion: https://postgr.es/m/CAAJ_b94hXQzXaJxTLShkxQUgezf_SUxhzX9TH2f-g6gP7bne7g@mail.gmail.com
src/backend/commands/copyfrom.c