Fix query result leak during binary upgrade
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 15 May 2024 20:48:51 +0000 (22:48 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 15 May 2024 20:48:51 +0000 (22:48 +0200)
commita8f87d5d21c2f3ddd644c9cb313ecd43290a446e
tree1a98ead6f7b56ae230115718ef4b746a70e776d3
parent98b4f53d156efe09294d6e1d62a5b52f544eee29
Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15
src/bin/pg_dump/pg_dump.c