Allow non-quoted identifiers as isolation test session/step names.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 23 Jun 2021 22:41:39 +0000 (18:41 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 23 Jun 2021 22:41:39 +0000 (18:41 -0400)
commita443c1b2d6a646cf90a8afc193c07ed12a2bf045
tree8ca5a1464d0faf5b2ea2b0d5dc336d860f03da7e
parent2031e1668e5577e64cfed29da69a34903d5a5227
Allow non-quoted identifiers as isolation test session/step names.

For no obvious reason, isolationtester has always insisted that
session and step names be written with double quotes.  This is
fairly tedious and does little for test readability, especially
since the names that people actually choose almost always look
like normal identifiers.  Hence, let's tweak the lexer to allow
SQL-like identifiers not only double-quoted strings.

(They're SQL-like, not exactly SQL, because I didn't add any
case-folding logic.  Also there's no provision for U&"..." names,
not that anyone's likely to care.)

There is one incompatibility introduced by this change: if you write
"foo""bar" with no space, that used to be taken as two identifiers,
but now it's just one identifier with an embedded quote mark.

I converted all the src/test/isolation/ specfiles to remove
unnecessary double quotes, but stopped there because my
eyes were glazing over already.

Like 741d7f104, back-patch to all supported branches, so that this
isn't a stumbling block for back-patching isolation test changes.

Discussion: https://postgr.es/m/759113.1623861959@sss.pgh.pa.us
104 files changed:
contrib/test_decoding/specs/oldest_xmin.spec
src/test/isolation/README
src/test/isolation/specparse.y
src/test/isolation/specs/aborted-keyrevoke.spec
src/test/isolation/specs/alter-table-1.spec
src/test/isolation/specs/alter-table-2.spec
src/test/isolation/specs/alter-table-3.spec
src/test/isolation/specs/alter-table-4.spec
src/test/isolation/specs/async-notify.spec
src/test/isolation/specs/classroom-scheduling.spec
src/test/isolation/specs/create-trigger.spec
src/test/isolation/specs/deadlock-hard.spec
src/test/isolation/specs/deadlock-parallel.spec
src/test/isolation/specs/deadlock-simple.spec
src/test/isolation/specs/deadlock-soft-2.spec
src/test/isolation/specs/deadlock-soft.spec
src/test/isolation/specs/delete-abort-savept-2.spec
src/test/isolation/specs/delete-abort-savept.spec
src/test/isolation/specs/detach-partition-concurrently-1.spec
src/test/isolation/specs/detach-partition-concurrently-2.spec
src/test/isolation/specs/detach-partition-concurrently-3.spec
src/test/isolation/specs/detach-partition-concurrently-4.spec
src/test/isolation/specs/drop-index-concurrently-1.spec
src/test/isolation/specs/eval-plan-qual-trigger.spec
src/test/isolation/specs/eval-plan-qual.spec
src/test/isolation/specs/fk-contention.spec
src/test/isolation/specs/fk-deadlock.spec
src/test/isolation/specs/fk-deadlock2.spec
src/test/isolation/specs/fk-partitioned-1.spec
src/test/isolation/specs/fk-partitioned-2.spec
src/test/isolation/specs/freeze-the-dead.spec
src/test/isolation/specs/horizons.spec
src/test/isolation/specs/index-only-scan.spec
src/test/isolation/specs/inherit-temp.spec
src/test/isolation/specs/insert-conflict-do-nothing-2.spec
src/test/isolation/specs/insert-conflict-do-nothing.spec
src/test/isolation/specs/insert-conflict-do-update-2.spec
src/test/isolation/specs/insert-conflict-do-update-3.spec
src/test/isolation/specs/insert-conflict-do-update.spec
src/test/isolation/specs/insert-conflict-specconflict.spec
src/test/isolation/specs/lock-committed-keyupdate.spec
src/test/isolation/specs/lock-committed-update.spec
src/test/isolation/specs/lock-update-delete.spec
src/test/isolation/specs/lock-update-traversal.spec
src/test/isolation/specs/multiple-cic.spec
src/test/isolation/specs/multiple-row-versions.spec
src/test/isolation/specs/multixact-no-deadlock.spec
src/test/isolation/specs/multixact-no-forget.spec
src/test/isolation/specs/nowait-2.spec
src/test/isolation/specs/nowait-3.spec
src/test/isolation/specs/nowait-4.spec
src/test/isolation/specs/nowait-5.spec
src/test/isolation/specs/nowait.spec
src/test/isolation/specs/partial-index.spec
src/test/isolation/specs/partition-concurrent-attach.spec
src/test/isolation/specs/partition-key-update-1.spec
src/test/isolation/specs/partition-key-update-2.spec
src/test/isolation/specs/partition-key-update-3.spec
src/test/isolation/specs/partition-key-update-4.spec
src/test/isolation/specs/plpgsql-toast.spec
src/test/isolation/specs/predicate-gin.spec
src/test/isolation/specs/predicate-gist.spec
src/test/isolation/specs/predicate-hash.spec
src/test/isolation/specs/predicate-lock-hot-tuple.spec
src/test/isolation/specs/prepared-transactions-cic.spec
src/test/isolation/specs/prepared-transactions.spec
src/test/isolation/specs/project-manager.spec
src/test/isolation/specs/propagate-lock-delete.spec
src/test/isolation/specs/read-only-anomaly-2.spec
src/test/isolation/specs/read-only-anomaly-3.spec
src/test/isolation/specs/read-only-anomaly.spec
src/test/isolation/specs/read-write-unique-2.spec
src/test/isolation/specs/read-write-unique-3.spec
src/test/isolation/specs/read-write-unique-4.spec
src/test/isolation/specs/read-write-unique.spec
src/test/isolation/specs/receipt-report.spec
src/test/isolation/specs/referential-integrity.spec
src/test/isolation/specs/reindex-concurrently.spec
src/test/isolation/specs/reindex-schema.spec
src/test/isolation/specs/ri-trigger.spec
src/test/isolation/specs/sequence-ddl.spec
src/test/isolation/specs/serializable-parallel-2.spec
src/test/isolation/specs/serializable-parallel.spec
src/test/isolation/specs/simple-write-skew.spec
src/test/isolation/specs/skip-locked-2.spec
src/test/isolation/specs/skip-locked-3.spec
src/test/isolation/specs/skip-locked-4.spec
src/test/isolation/specs/skip-locked.spec
src/test/isolation/specs/temporal-range-integrity.spec
src/test/isolation/specs/timeouts.spec
src/test/isolation/specs/total-cash.spec
src/test/isolation/specs/truncate-conflict.spec
src/test/isolation/specs/tuplelock-conflict.spec
src/test/isolation/specs/tuplelock-partition.spec
src/test/isolation/specs/tuplelock-update.spec
src/test/isolation/specs/tuplelock-upgrade-no-deadlock.spec
src/test/isolation/specs/two-ids.spec
src/test/isolation/specs/update-conflict-out.spec
src/test/isolation/specs/update-locked-tuple.spec
src/test/isolation/specs/vacuum-concurrent-drop.spec
src/test/isolation/specs/vacuum-conflict.spec
src/test/isolation/specs/vacuum-reltuples.spec
src/test/isolation/specs/vacuum-skip-locked.spec
src/test/isolation/specscanner.l