postgres_fdw: Fix subabort cleanup of connections used in asynchronous execution.
authorEtsuro Fujita <efujita@postgresql.org>
Fri, 21 Jan 2022 08:45:00 +0000 (17:45 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Fri, 21 Jan 2022 08:45:00 +0000 (17:45 +0900)
commit6c07f9ebce1579612c4ed9076159f9e942e50f9d
tree0832a3c9718df2eee69cb8f2b959405744df50f8
parent237d1f317240b60b3fff698f4e9b184d1db83a6e
postgres_fdw: Fix subabort cleanup of connections used in asynchronous execution.

Commit 27e1f1456 resets the per-connection states of connections used to
scan foreign tables asynchronously during abort cleanup at main
transaction end, but it failed to do so during subabort cleanup at
subtransaction end, leading to a segmentation fault when re-executing an
asynchronous-foreign-table-scan query in a transaction that was
cancelled in a subtransaction of it.

Fix by modifying pgfdw_abort_cleanup() to reset the per-connection state
of a given connection also when called for subabort cleanup.  Also,
modify that function to do the reset in both the abort-cleanup and
subabort-cleanup cases if necessary, to save cycles, and improve a
comment on it a little bit.

Back-patch to v14 where the aforesaid commit came in.

Reviewed by Alexander Pyhalov

Discussion: https://postgr.es/m/CAPmGK14cCV-JA7kNsyt2EUTKvZ4xkr2LNRthi1U1C3cqfGppAw@mail.gmail.com
contrib/postgres_fdw/connection.c