Relax assertion in finding correct GiST parent
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 4 Apr 2025 10:49:00 +0000 (13:49 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 4 Apr 2025 10:49:21 +0000 (13:49 +0300)
commit6526d07948c58fd83a71a902bea8caa793c9c4b8
tree9fc2f2073935feb265f9c636263ba8304cc98e77
parentc88b36d382ebb7925db9f713dcf5ad8ca1bbae71
Relax assertion in finding correct GiST parent

Commit 28d3c2ddcf introduced an assertion that if the memorized
downlink location in the insertion stack isn't valid, the parent's
LSN should've changed too. Turns out that was too strict. In
gistFindCorrectParent(), if we walk right, we update the parent's
block number and clear its memorized 'downlinkoffnum'. That triggered
the assertion on next call to gistFindCorrectParent(), if the parent
needed to be split too. Relax the assertion, so that it's OK if
downlinkOffnum is InvalidOffsetNumber.

Backpatch to v13-, all supported versions. The assertion was added in
commit 28d3c2ddcf in v12.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://www.postgresql.org/message-id/18396-03cac9beb2f7aac3@postgresql.org
src/backend/access/gist/gist.c